Kill the KinfoCenter binary
ClosedPublic

Authored by mart on Jan 24 2020, 12:54 PM.

Details

Summary

Remove the binary, only install the modules and categories.
The categories have been reorganized a bit to be compatible with SystemSettings
Depends from D26895

Test Plan

Diff Detail

Repository
R102 KInfoCenter
Branch
mart/kinfoCenterMode
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21704
Build 21722: arc lint + arc unit
mart created this revision.Jan 24 2020, 12:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2020, 12:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Jan 24 2020, 12:54 PM
mart edited the summary of this revision. (Show Details)Jan 24 2020, 12:58 PM
mart edited the test plan for this revision. (Show Details)

Assuming the other gets in, ship it!

CMakeLists.txt
25

We can probably get rid of at least this. Maybe quite a few others

Would it make sense to keep a kinfocenter script that just launchers systemsettings5 -i for compat?
Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the Exec for that if this name is in the desktop file somewhere other than that.

Would it make sense to keep a kinfocenter script that just launchers systemsettings5 -i for compat?
Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the Exec for that if this name is in the desktop file somewhere other than that.

+1, would be nice to keep the old name around somehow for compatibility. We are shooting for enterprise-grade after all, and those folks hate this kind of renaming that breaks their custom scripts.

mart updated this revision to Diff 74433.Jan 27 2020, 3:07 PM
  • link kinfocenter to systemsettings5
mart updated this revision to Diff 74434.Jan 27 2020, 3:09 PM
  • back to kinfocenter bin name
davidedmundson accepted this revision.Jan 28 2020, 1:11 PM
davidedmundson added inline comments.
CMakeLists.txt
106

comments for future devs explaining the situation would be useful

This revision is now accepted and ready to land.Jan 28 2020, 1:11 PM
This revision was automatically updated to reflect the committed changes.
jjazeix added inline comments.
CMakeLists.txt
83

Removing this file is breaking the compilation: https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/

05:48:56  In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:
05:48:56  /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found
05:48:56  #include <config-X11.h>
05:48:56           ^~~~~~~~~~~~~~