Remove the binary, only install the modules and categories.
The categories have been reorganized a bit to be compatible with SystemSettings
Depends from D26895
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R102:24f4c6f97875: Kill the KinfoCenter binary
Diff Detail
- Repository
- R102 KInfoCenter
- Branch
- mart/kinfoCenterMode
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21704 Build 21722: arc lint + arc unit
Assuming the other gets in, ship it!
CMakeLists.txt | ||
---|---|---|
25 | We can probably get rid of at least this. Maybe quite a few others |
Would it make sense to keep a kinfocenter script that just launchers systemsettings5 -i for compat?
Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the Exec for that if this name is in the desktop file somewhere other than that.
+1, would be nice to keep the old name around somehow for compatibility. We are shooting for enterprise-grade after all, and those folks hate this kind of renaming that breaks their custom scripts.
CMakeLists.txt | ||
---|---|---|
106 | comments for future devs explaining the situation would be useful |
CMakeLists.txt | ||
---|---|---|
83 | Removing this file is breaking the compilation: https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/ 05:48:56 In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24: 05:48:56 /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found 05:48:56 #include <config-X11.h> 05:48:56 ^~~~~~~~~~~~~~ |