Differential D26893

Fix a building issue
ClosedPublic
Actions

Authored by meven on Jan 24 2020, 11:26 AM.

Details

Reviewers
ngraham
rikmills
jriddell
Group Reviewers
Plasma
Commits
R128:e1569e3341e7: Fix a building issue
Summary

Build regression introduced in D26847

https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console

Test Plan

Builds

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 24 2020, 11:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2020, 11:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 24 2020, 11:26 AM
jriddell accepted this revision as: jriddell.Jan 28 2020, 2:49 PM
jriddell added a subscriber: jriddell.

Add this patch fixes compile on the KDE neon CI https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/

Curiously I can't recreate the failure on my local computer

This revision is now accepted and ready to land.Jan 28 2020, 2:49 PM
Closed by commit R128:e1569e3341e7: Fix a building issue (authored by meven). · Explain WhyJan 28 2020, 4:11 PM
This revision was automatically updated to reflect the committed changes.
meven added a comment.Jan 28 2020, 4:13 PM
In D26893#601874, @jriddell wrote:

Add this patch fixes compile on the KDE neon CI https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/

Curiously I can't recreate the failure on my local computer

Me neither, or this build issue would not have been committed.
Maybe because of the Qt version, I have 5.12.

Can't wait for gitlab pre-merge branch test...

Revision Contents
Changeset List

PathPackages
Msrc/usermanager.cpp (2 lines)

Diff 74507

View Options

src/usermanager.cpp

Loading...