[Applets/Folder View] Allow using a folder that ends with a space
AbandonedPublic

Authored by ngraham on Jan 23 2020, 5:54 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

QUrl::fromLocalFile is otherwise appropriate but automatically strips a trailing space,
which we don't want. This patch explicitly handles that case.

CCBUG: 407671

Test Plan

Configure Folder View applet
Enter a valid path to a folder whose name ends with a space
It works

Diff Detail

Repository
R119 Plasma Desktop
Branch
allow-adding-folders-that-end-with-a-space (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21597
Build 21615: arc lint + arc unit
ngraham created this revision.Jan 23 2020, 5:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 23 2020, 5:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 23 2020, 5:54 PM

That's somewhat oddly spcific, isn't it? I'd be surprised that fromLocalFile strips trailing spaces? :0

If url ends with more than one space?

ngraham abandoned this revision.Tue, May 19, 5:28 PM

What a silly little patch this was.