Differential D26876

Remove the Enum hack: finish lists with a comma, it's valid c++
AcceptedPublic
Actions

Authored by tcanabrava on Jan 23 2020, 4:03 PM.

Details

Reviewers
ervin
dfaure
apol
Test Plan

Run tests

Diff Detail

Repository
R237 KConfig
Branch
remove_enum_hack
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21797
Build 21815: arc lint + arc unit
tcanabrava created this revision.Jan 23 2020, 4:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 23 2020, 4:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jan 23 2020, 4:03 PM
apol accepted this revision.Jan 24 2020, 6:17 PM
This revision is now accepted and ready to land.Jan 24 2020, 6:17 PM
ervin added inline comments.Jan 28 2020, 5:46 PM
src/kconfig_compiler/KConfigHeaderGenerator.cpp
252–268

I lost track of constness here so I might be wrong, shouldn't this use qAsConst in this context?

tcanabrava updated this revision to Diff 74596.Jan 29 2020, 5:24 PM
tcanabrava marked an inline comment as done.
  • Use qAsConst
tcanabrava added a comment.Jan 29 2020, 5:24 PM

update / rebased.

src/kconfig_compiler/KConfigHeaderGenerator.cpp
252–268

yeah.

ervin added inline comments.Jan 31 2020, 10:47 AM
src/kconfig_compiler/KConfigHeaderGenerator.cpp
267

You use "const Signal &" a few lines below, makes me wonder shouldn't they both be "const auto &" then? at least for consistency?

Revision Contents
Changeset List

Diff 74596

View Options

autotests/kconfig_compiler/test13.h.ref

Loading...
View Options

autotests/kconfig_compiler/test_signal.h.ref

Loading...
View Options

src/kconfig_compiler/KConfigHeaderGenerator.cpp

Loading...