Differential D26853

Improve OpenGL vendor string normalization
ClosedPublic
Actions

Authored by vkrause on Jan 22 2020, 8:44 PM.

Details

Reviewers
apol
Commits
R849:992fd79534de: Improve OpenGL vendor string normalization
Summary

Strips the leading profile information on newer Mesa stacks (we have that
separately already anyway). Based on initial Plasma telemetry.

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause requested review of this revision.Jan 22 2020, 8:44 PM
vkrause created this revision.
apol added a comment.Jan 23 2020, 1:02 AM

Didn't I accept this already somewhere else? >.<

vkrause added a comment.Jan 23 2020, 7:37 AM
In D26853#599329, @apol wrote:

Didn't I accept this already somewhere else? >.<

You approved the very similarly named D26852, but that's for a different field in the OpenGL data :)

apol accepted this revision.Jan 23 2020, 11:07 AM

of course, apologies.

This revision is now accepted and ready to land.Jan 23 2020, 11:07 AM
Closed by commit R849:992fd79534de: Improve OpenGL vendor string normalization (authored by vkrause). · Explain WhyJan 23 2020, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74266

View Options

autotests/openglinfosourcetest.cpp

Loading...
View Options

src/provider/core/openglinfosource_p.h

Loading...