Don't outline characters in formula rendering.
ClosedPublic

Authored by akreuzkamp on Sep 6 2016, 7:18 PM.

Details

Summary

Characters in formula rendering used to look like super-bold, because
they're rendered into a vector path and have a pen set. This patch
simply sets the pen to Qt::NoPen before painting text.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akreuzkamp updated this revision to Diff 6499.Sep 6 2016, 7:18 PM
akreuzkamp retitled this revision from to Don't outline characters in formula rendering..
akreuzkamp updated this object.
akreuzkamp edited the test plan for this revision. (Show Details)
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptSep 6 2016, 7:18 PM
kossebau accepted this revision.Sep 6 2016, 10:28 PM
kossebau added a reviewer: kossebau.
kossebau added a subscriber: kossebau.

Good find and improvement, thanks. Seems this is a Qt4->Qt5 regression, as QPen(QColor) changed default width from 0 to 1 pixels. Will have a look at other places once this is in.
Please push :)

plugins/formulashape/elements/TokenElement.cpp
64

Please no spaces between brackets and value (code style of Calligra code is incrementally adapted on each fix).

This revision is now accepted and ready to land.Sep 6 2016, 10:28 PM

And this is less a regression by Qt4->Qt5, but indeed a mistake in the code since it was written, now I see better. There is no purpose to draw an outline here, agree to your analysis. The Qt5 change of default QPen values just made this more obvious :)

This revision was automatically updated to reflect the committed changes.