Differential D26845

[context menu] Remove last traces of "Lock Widgets" action from UI
ClosedPublic
Actions

Authored by ngraham on Jan 22 2020, 4:47 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:66940389d66b: [context menu] Remove last traces of "Lock Widgets" action from UI
Summary

In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.

This patch removes it from those places

BUG: 416578
FIXED-IN: 5.18.0

Test Plan

Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.

Please review carefully as this code is fairly unfamiliar to me.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 22 2020, 4:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2020, 4:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 22 2020, 4:47 PM
mart accepted this revision.Jan 30 2020, 3:40 PM
This revision is now accepted and ready to land.Jan 30 2020, 3:40 PM
Closed by commit R120:66940389d66b: [context menu] Remove last traces of "Lock Widgets" action from UI (authored by ngraham). · Explain WhyJan 30 2020, 3:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74707

View Options

containmentactions/contextmenu/menu.cpp

Loading...