Differential D26834

libnotificationmanager : deprecate Settings ctor that takes a config
ClosedPublic
Actions

Authored by crossi on Jan 22 2020, 10:58 AM.

Details

Reviewers
ervin
broulik
Commits
R120:ea08681efe5e: libnotificationmanager : deprecate Settings ctor that takes a config
Summary

Unused

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Jan 22 2020, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2020, 10:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Jan 22 2020, 10:58 AM
crossi planned changes to this revision.Jan 22 2020, 12:45 PM
broulik added inline comments.Jan 22 2020, 12:47 PM
libnotificationmanager/settings.cpp
45

Global statics are to be avoided in libraries

186

I prefer to have a name and then explicitly Q_UNUSED in the function body

crossi updated this revision to Diff 74116.Jan 22 2020, 1:57 PM

Use config param in ctor. Avoid global static object as per library code policy.

ervin added inline comments.Jan 29 2020, 9:21 AM
libnotificationmanager/settings.cpp
40

I don't think that's what Kai had in mind regarding his comment. @broulik could you confirm?

crossi added a comment.Feb 25 2020, 10:28 AM

@broulik any thoughts on this ?

broulik accepted this revision.Feb 25 2020, 3:05 PM
This revision is now accepted and ready to land.Feb 25 2020, 3:05 PM
crossi updated this revision to Diff 76379.Feb 25 2020, 3:26 PM

constexpr instead of static

crossi updated this revision to Diff 76380.Feb 25 2020, 3:27 PM

constexpr

ervin accepted this revision.Feb 25 2020, 4:17 PM
Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings ctor that takes a config (authored by crossi). · Explain WhyFeb 25 2020, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76394

View Options

libnotificationmanager/settings.h

Loading...
View Options

libnotificationmanager/settings.cpp

Loading...