Consider empty email valid
ClosedPublic

Authored by meven on Wed, Jan 22, 8:59 AM.

Details

Summary

BUG: 411736
FIXED-IN: 5.18

Test Plan
  1. open system settings > account details > user manager
  2. type an email address to your user account
  3. click on "Apply" button, type your password and press enter/return to confirm
  4. close the User Manager and reopen it
  5. clear the email address field
  6. Apply

The empty email is saved.

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Wed, Jan 22, 8:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jan 22, 8:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Wed, Jan 22, 8:59 AM
meven added a comment.Wed, Jan 22, 9:00 AM

Good candidate for Plasma/5.18

Can't go in 5.18 because you added a new string. That part would need to go on master. So either this whole thing goes on master, or the bug gets fixed in 5.18 and the new messagebox goes on master.

meven planned changes to this revision.Wed, Jan 22, 3:54 PM

Can't go in 5.18 because you added a new string. That part would need to go on master. So either this whole thing goes on master, or the bug gets fixed in 5.18 and the new messagebox goes on master.

Allright I will split this.

meven updated this revision to Diff 74133.Wed, Jan 22, 3:56 PM

Remove change that added a string

meven retitled this revision from Consider empty email valid, warn user when changing selected user about potential data loss to Consider empty email valid.Wed, Jan 22, 4:00 PM
meven edited the summary of this revision. (Show Details)
meven edited the test plan for this revision. (Show Details)
meven edited the summary of this revision. (Show Details)Wed, Jan 22, 4:04 PM
meven edited the test plan for this revision. (Show Details)
ngraham added inline comments.Wed, Jan 22, 5:58 PM
src/accountinfo.cpp
364

This seems like the only part of the patch that's actually about fixing the issue. The rest seems to be unrelated code cleanup that should be probably be done separately.

meven planned changes to this revision.Wed, Jan 22, 5:59 PM
meven added inline comments.
src/accountinfo.cpp
364

Yes, will do that separately...

meven edited the summary of this revision. (Show Details)Wed, Jan 22, 6:11 PM
meven updated this revision to Diff 74157.Wed, Jan 22, 6:12 PM

Only fix bug

meven marked 2 inline comments as done.Wed, Jan 22, 6:12 PM
ngraham accepted this revision.Wed, Jan 22, 8:07 PM

Thanks!

This revision is now accepted and ready to land.Wed, Jan 22, 8:07 PM
This revision was automatically updated to reflect the committed changes.