Porting done by clazy.
Details
- Reviewers
zzag - Group Reviewers
Plasma - Commits
- R31:4edf2cc98352: Port connections to new syntax
Compiles
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
++
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 | Does clazy handle overloaded signals and slots? |
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 | Sort of. There's about 24 left in this repo. |
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 | Hmm, so one has to port them by hand, right? |
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 | Effectively, yes. I've been slowly going through all of Plasma, but a lot remain. There's a combo of:
|
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 |
Do you want to port them in this patch or in another one? |
kdecoration/config/breezeconfigwidget.cpp | ||
---|---|---|
49 | I would prefer separately as then it's clear to a reviewer which ones need potentially more checking. |
This breaks the KDE4 compilation of breeze style (of course !)
So if this patch is to stay, then one should officially drop the kde4 support (or make a branch for it).
In that case, much more code can go (a lot of QT Version ifdefs, some CMake magic, etc.)
Otherwise, the kstyle part of this patch at least, should be reverted.
To compile with kde4:
cmake -DUSE_KDE4=1
I know that some distributions (Fedora31 which I am using) do ship the kde4 version of the breeze style.
Qt 4 build was dropped.
https://mail.kde.org/pipermail/plasma-devel/2020-January/108585.html
yeah ok. Just noted this. indeed.
Sorry, I assumed you had seen the thread.
Hope you're ok with it?
Sure thing ! The whole thing is more modern and easier to maintain for everybody. Glad to see Qt4 going !