Port connections to new syntax
ClosedPublic

Authored by davidedmundson on Jan 22 2020, 1:01 AM.

Details

Summary

Porting done by clazy.

Test Plan

Compiles

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 22 2020, 1:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 22 2020, 1:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 22 2020, 1:01 AM
zzag added a subscriber: zzag.Jan 22 2020, 1:04 AM

++

kdecoration/config/breezeconfigwidget.cpp
49

Does clazy handle overloaded signals and slots?

davidedmundson added inline comments.Jan 22 2020, 1:08 AM
kdecoration/config/breezeconfigwidget.cpp
49

Sort of.
It handles not doing anything bad. It detects it and prints a warning.

There's about 24 left in this repo.

zzag added inline comments.Jan 22 2020, 10:01 AM
kdecoration/config/breezeconfigwidget.cpp
49

Hmm, so one has to port them by hand, right?

kdecoration/config/breezeconfigwidget.cpp
49

Effectively, yes.

I've been slowly going through all of Plasma, but a lot remain.

There's a combo of:

  • overloaded signals/slots
  • Q_PRIVATE_SLOT (which probably could be automated)
  • signals on a derived class for upcasted objects
zzag added inline comments.Jan 22 2020, 10:29 AM
kdecoration/config/breezeconfigwidget.cpp
49

There's about 24 left in this repo.

Do you want to port them in this patch or in another one?

kdecoration/config/breezeconfigwidget.cpp
49

I would prefer separately as then it's clear to a reviewer which ones need potentially more checking.

zzag accepted this revision.Jan 22 2020, 10:54 AM
This revision is now accepted and ready to land.Jan 22 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.

This breaks the KDE4 compilation of breeze style (of course !)
So if this patch is to stay, then one should officially drop the kde4 support (or make a branch for it).
In that case, much more code can go (a lot of QT Version ifdefs, some CMake magic, etc.)
Otherwise, the kstyle part of this patch at least, should be reverted.

To compile with kde4:
cmake -DUSE_KDE4=1

I know that some distributions (Fedora31 which I am using) do ship the kde4 version of the breeze style.

zzag added a comment.Jan 22 2020, 4:35 PM

This breaks the KDE4 compilation of breeze style (of course !)

Qt 4 build was dropped.

https://mail.kde.org/pipermail/plasma-devel/2020-January/108585.html

hpereiradacosta added a comment.EditedJan 22 2020, 4:36 PM
In D26823#599003, @zzag wrote:

This breaks the KDE4 compilation of breeze style (of course !)

Qt 4 build was dropped.

https://mail.kde.org/pipermail/plasma-devel/2020-January/108585.html

yeah ok. Just noted this. indeed.
Up to you I guess.
Please ignore previous message

yeah ok. Just noted this. indeed.

Sorry, I assumed you had seen the thread.
Hope you're ok with it?

yeah ok. Just noted this. indeed.

Sorry, I assumed you had seen the thread.
Hope you're ok with it?

Sure thing ! The whole thing is more modern and easier to maintain for everybody. Glad to see Qt4 going !