Differential D26818

Fix missing link libraries to CMakeLists.txt
Needs RevisionPublic
Actions

Authored by hgoebel on Jan 21 2020, 10:56 PM.

Details

Reviewers
krop
Group Reviewers
KDE PIM: Junior Jobs
Summary

These are only actually missing if the libraries reside in different
prefixes, as it is the case in Guix or Nix.

Diff Detail

Repository
R91 PIM: Sieve Handling Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
hgoebel created this revision.Jan 21 2020, 10:56 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 21 2020, 10:56 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
hgoebel requested review of this revision.Jan 21 2020, 10:56 PM
krop requested changes to this revision.Jan 22 2020, 7:40 AM
krop added a subscriber: krop.

If you need to add KF5::SyntaxHighlighting, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.

Looking at the installed headers, the only one needing a syntaxhighlighting header is sievedebugdialog.h. This header is only used by sievedebugdialog.cpp which is built by the KF5KSieveUi target.

Conclusion: what needs fixing is src/ksieveui/CMakeLists.txt where KF5::SyntaxHighlighting shall be moved to the PUBLIClink targets.

This revision now requires changes to proceed.Jan 22 2020, 7:40 AM

Revision Contents
Changeset List

Diff 74050

View Options

src/ksieveui/autocreatescripts/tests/CMakeLists.txt

Loading...
View Options

src/ksieveui/scriptsparsing/autotests/CMakeLists.txt

Loading...
View Options

src/ksieveui/scriptsparsing/tests/CMakeLists.txt

Loading...