Differential D26814

[kcms/kwindecoration] Fix saving of window decoration plugin
ClosedPublic
Actions

Authored by davidedmundson on Jan 21 2020, 6:22 PM.

Details

Reviewers
ngraham
Group Reviewers
KWin
Commits
R108:e0df390dbc24: [kcms/kwindecoration] Fix saving of window decoration plugin
Summary

In the KCFG autogenerated code we check for HAVE_BREEZE_DECO without
including the relevant file. This always fails, and so we save the
default plugin name/library as org.kde.kwin.aurorae

This doesn't match kwin's concept of the default and so we just fail to
load it.

BUG: 416525

Test Plan

Reproduced
Saved a config

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 21 2020, 6:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 21 2020, 6:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 21 2020, 6:22 PM
ngraham accepted this revision.Jan 21 2020, 6:33 PM
ngraham added a subscriber: ngraham.

Fixes the bug.

This revision is now accepted and ready to land.Jan 21 2020, 6:33 PM
Closed by commit R108:e0df390dbc24: [kcms/kwindecoration] Fix saving of window decoration plugin (authored by davidedmundson). · Explain WhyJan 21 2020, 6:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74040

View Options

kcmkwin/kwindecoration/kwindecorationsettings.kcfg

Loading...