Differential D26811

Fix crash in variable expansion (used by external tools)
ClosedPublic
Actions

Authored by dhaumann on Jan 21 2020, 5:13 PM.

Details

Reviewers
cullmann
Commits
R39:22fa707eb7e2: Fix crash in variable expansion (used by external tools)
Summary

findClosing() is already called with +2 to account for the
starting %{ characters. So we start at the given pos and
increment it only after the while loop. Unbalanced cases
of '{' and '}' are now also unit tested.

Test Plan

make && make test

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Jan 21 2020, 5:13 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 21 2020, 5:13 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Jan 21 2020, 5:13 PM
cullmann accepted this revision.Jan 21 2020, 5:28 PM
This revision is now accepted and ready to land.Jan 21 2020, 5:28 PM
Closed by commit R39:22fa707eb7e2: Fix crash in variable expansion (used by external tools) (authored by dhaumann). · Explain WhyJan 21 2020, 5:33 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 74033