Differential D26800

autotests: use local desktop file to avoid relying on konsole
ClosedPublic
Actions

Authored by dfaure on Jan 20 2020, 10:40 PM.

Details

Reviewers
meven
apol
Commits
R309:2d75bedd6ca0: autotests: use local desktop file to avoid relying on konsole
Summary

Test was unstable since konsole commit : https://cgit.kde.org/konsole.git/commit/desktop/org.kde.konsole.desktop?id=7e83be47192c3bfb097a48dde0292bc7da0ef272

Test Plan

make && ctest

Diff Detail

Repository
R309 KService
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21415
Build 21433: arc lint + arc unit
dfaure created this revision.Jan 20 2020, 10:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 20 2020, 10:40 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jan 20 2020, 10:40 PM
meven added inline comments.Jan 20 2020, 10:46 PM
autotests/org.kde.testapp.desktop
6

Add NoDisplay or testiers will have double konsole, or remove test desktop file on teardown.

dfaure added a comment.Jan 20 2020, 10:55 PM

It's not installed.

apol accepted this revision.Jan 21 2020, 3:16 AM
This revision is now accepted and ready to land.Jan 21 2020, 3:16 AM
dfaure closed this revision.Jan 21 2020, 8:33 AM
dfaure added inline comments.Jan 21 2020, 9:51 AM
autotests/kservicetest.cpp
73

(to expand on my previous reply: this line ensures that we copy the desktop files into a test-specific directory)

meven added inline comments.Jan 21 2020, 10:09 AM
autotests/kservicetest.cpp
73

Thanks, did not notice this line and did not know setTestModeEnabled
Learning every day...

Revision Contents
Changeset List

Diff 73982

View Options

autotests/kservicetest.cpp

Loading...
View Options

autotests/org.kde.testapp.desktop

Loading...