[Notifications] When there is only a reply action, show reply field right away
ClosedPublic
Actions

Authored by broulik on Jan 20 2020, 5:06 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

Summary

Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.

Test Plan

Since quick reply isn't really used anywhere yet I would like to have this in 5.18

Sent notification with only inline-reply action, got text field right away, clicking it focused the text field properly
Sent notification with inline-reply + another action, got two buttons, inline-reply button revealed text field and focused it properly autoamtically
Verified that "default" action did not count as an action in this calculation

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jan 20 2020, 5:06 PM

This revision is now accepted and ready to land.Jan 21 2020, 12:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/notifications/package/contents/ui/NotificationItem.qml (75 lines)
M			applets/notifications/package/contents/ui/NotificationReplyField.qml (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73972			Jan 20 2020, 5:03 PM	★	★
Diff 2	73998			Jan 21 2020, 9:32 AM	★	★
Diff 3	74010	5369cf7	R120:3328f6a2f5adffd87408b9eac4683f3d10571a43	Jan 21 2020, 12:32 PM	★	★