[Notifications] When there is only a reply action, show reply field right away
ClosedPublic

Authored by broulik on Jan 20 2020, 5:06 PM.

Details

Summary

Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.

Test Plan

Since quick reply isn't really used anywhere yet I would like to have this in 5.18

  • Sent notification with only inline-reply action, got text field right away, clicking it focused the text field properly
  • Sent notification with inline-reply + another action, got two buttons, inline-reply button revealed text field and focused it properly autoamtically
  • Verified that "default" action did not count as an action in this calculation

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 20 2020, 5:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2020, 5:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 20 2020, 5:06 PM
broulik updated this revision to Diff 73998.Jan 21 2020, 9:32 AM
  • Move MouseArea inside as to not break the RowLayout
davidedmundson accepted this revision.Jan 21 2020, 12:24 PM
This revision is now accepted and ready to land.Jan 21 2020, 12:24 PM
This revision was automatically updated to reflect the committed changes.