Details

Reviewers: None

Summary

This is a work in progress for adding support for posting comments
to the KNewStuffCore framework, and cleaning up voting a touch. It
further adds UI for creating said comments to KNSQuick.

Add signals to fake a virtual function for posting a comment
Implement comment posting (and userCanVote check)
Add invokable functions for creating comments (and reviews)
Add voting function to the quickitemsmodel (and userCanVote role)
Entry details checks for voting ability
Don't allow voting from the list view (in the old dialog)
Allow clearing the Rating control when it's editable
Add vote requesting feature to the Rating control (separate from editable), to allow the user to vote without changing the existing value (which should be updated elsewhere)
"New Comment" component created to allow making new comments, replies to comments, and reviews
Added New Comment to the entry comments page, and replying to the comment delegates
Added New Comment to the entry details page, which can be activated when an entry has no comments already
Add reply request functionality to the comment delegate
Add calls through to Attica for requesting editing of user credentials (which uses the code in D25961, which launches the kaccounts kcm to allow the user to log in to their opendesktop.org account)
If the user is marked as not allowed to vote, attempting to comment or vote will request the credentials editor

This does not strictly require D25961, but without it this will simply not allow voting and commenting with the attica backend

The entry details page if there are no comments:

The new comment sheet without having picked a star rating:

The comments page (note the reply and new comment actions):

The new comment sheet with a star rating picked (and fields filled out):

The new comment sheet when creating a reply (also showing what happens if the sheet is hidden and shown again without submission - contents are retained, reducing potential for data loss):

BUG:418995

Diff Detail

Repository

R304 KNewStuff

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21571
Build 21589: arc lint + arc unit

leinir created this revision.Jan 20 2020, 2:37 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 20 2020, 2:37 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

leinir requested review of this revision.Jan 20 2020, 2:37 PM

Harbormaster completed remote builds in B21396: Diff 73944.Jan 20 2020, 2:37 PM

Allow clearing the Rating control when editable
Initial new-comment sheet (needs some layout work)

Harbormaster completed remote builds in B21436: Diff 74016.Jan 21 2020, 1:51 PM

leinir edited the summary of this revision. (Show Details)Jan 21 2020, 1:52 PM

Progressing steadily, with some layout fixing assistance from Marco.
Also, ensure you're using kirigami master for the best experience ;)

Forward the userCanComment information from the items model
Clean up the layouting of the comments sheet (thanks for the help, @mart!)
Add reply request functionality to the comment delegate

Harbormaster completed remote builds in B21489: Diff 74113.Jan 22 2020, 1:30 PM

leinir edited the summary of this revision. (Show Details)Jan 22 2020, 1:31 PM

Add a voting method to the Ratings component (separate to editable)
Use the votable prop to add voting UI to entry details
Hook up to the functions which do the actual vote/comment work

Harbormaster completed remote builds in B21493: Diff 74119.Jan 22 2020, 2:12 PM

leinir edited the summary of this revision. (Show Details)Jan 22 2020, 2:13 PM

Add editCredentials to the knscore provider interface
Implement edit credentials in the Attica provider
Add functionality to request a credentials editor from KNSCore::Engine
Add an invokable to the KNSQuick Engine for editing credentials
Call in and request the credentials editor if none exist

Harbormaster completed remote builds in B21556: Diff 74210.Jan 23 2020, 11:01 AM

leinir edited the summary of this revision. (Show Details)Jan 23 2020, 12:42 PM

Pull out the new comments sheet into a component
Use NewCommentSheet to let users create comments on entries without

Harbormaster completed remote builds in B21567: Diff 74225.Jan 23 2020, 1:05 PM

leinir edited the summary of this revision. (Show Details)Jan 23 2020, 1:07 PM

Don't suggest making reviews if you're writing a reply comment
Don't pull up a comments model until we actually need it

Harbormaster completed remote builds in B21568: Diff 74227.Jan 23 2020, 1:12 PM

leinir edited the summary of this revision. (Show Details)Jan 23 2020, 1:17 PM

leinir edited the summary of this revision. (Show Details)

Clarify the "be the first" text a touch...

Harbormaster completed remote builds in B21570: Diff 74229.Jan 23 2020, 1:26 PM

A better text for the "be the first" link (i'll try not dither too much)

Harbormaster completed remote builds in B21571: Diff 74230.Jan 23 2020, 1:28 PM

Right, so because it is being brought up by people, i thought i should perhaps just do a touch of an explanation for the thought process that made me arrive at the current design for the NewCommentSheet component and its ability to chose whether or not you are writing a comment or a review. The options that i found can be enumerated as follows:

*) This one (that is, one action shows a dialogue which lets the user switch between a comment being a review or just a comment by either setting a rating or not)
a) A check box to explicitly indicate that you want to create a review, which then enables/disables the ratings stars (so much clunkiness)
x) As above, but it hides/shows the ratings stars instead of enable/disable (ew, stuff moving under my cursor)
n) Two separate actions, one for creating a review, and one for creating a comment, and they then show a sheet which can only do one or the other (really just adding this in for completion, because wow, just no - also incidentally not a straightforward thing to do, as there's only the one main action on a kirigami page, though that's an overcomeable technical limitation rather than a workflow dictated one)

leinir edited the summary of this revision. (Show Details)Mar 19 2020, 1:33 PM

		Path
M		src/attica/atticaprovider.cpp (28 lines)
M		src/attica/atticaprovider_p.h (14 lines)
M		src/core/commentsmodel.h (27 lines)
M		src/core/commentsmodel.cpp (24 lines)
M		src/core/engine.h (7 lines)
M		src/core/engine.cpp (8 lines)
M		src/core/provider.h (44 lines)
M		src/qtquick/qml/EntryDetails.qml (31 lines)
M		src/qtquick/qml/private/EntryCommentDelegate.qml (19 lines)
M		src/qtquick/qml/private/EntryCommentsPage.qml (19 lines)
A	M	src/qtquick/qml/private/NewCommentSheet.qml (124 lines)
M		src/qtquick/qml/private/Rating.qml (21 lines)
M		src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml (3 lines)
M		src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml (3 lines)
M		src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml (3 lines)
M		src/qtquick/quickengine.h (7 lines)
M		src/qtquick/quickengine.cpp (7 lines)
M		src/qtquick/quickitemsmodel.h (14 lines)
M		src/qtquick/quickitemsmodel.cpp (14 lines)
M		src/ui/entrydetailsdialog.cpp (6 lines)
M		src/ui/itemsviewdelegate.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73944	198e589		Jan 20 2020, 2:37 PM	★	★
Diff 2	74016	198e589	- Allow clearing the Rating control when editable	Jan 21 2020, 1:51 PM	★	★
Diff 3	74113	198e589	Progressing steadily, with some layout fixing assistance from Marco.	Jan 22 2020, 1:30 PM	★	★
Diff 4	74119	198e589	- Add a voting method to the Ratings component (separate to editable)	Jan 22 2020, 2:12 PM	★	★
Diff 5	74210	198e589	- Add editCredentials to the knscore provider interface	Jan 23 2020, 11:01 AM	★	★
Diff 6	74225	198e589	- Pull out the new comments sheet into a component	Jan 23 2020, 1:05 PM	★	★
Diff 7	74227	198e589	- Don't suggest making reviews if you're writing a reply comment	Jan 23 2020, 1:12 PM	★	★
Diff 8	74229	198e589	- Clarify the "be the first" text a touch...	Jan 23 2020, 1:26 PM	★	★
Diff 9	74230	198e589	- A better text for the "be the first" link (i'll try not dither too much)	Jan 23 2020, 1:28 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3f2bdfe272b2	9a9145ad6545	4f8f57377624	Dan Leinir Turthra Jensen	A better text for the "be the first" link (i'll try not dither too much)	Jan 23 2020, 1:28 PM
4f8f57377624	47d3bf8489a4	ceb73bf5e76e	Dan Leinir Turthra Jensen	Clarify the "be the first" text a touch...	Jan 23 2020, 1:25 PM
ceb73bf5e76e	f12ccd624a08	dc18c2fa779c	Dan Leinir Turthra Jensen	Don't pull up a comments model until we actually need it	Jan 23 2020, 1:12 PM
dc18c2fa779c	eaaa595c2da6	7fcb67118b74	Dan Leinir Turthra Jensen	Don't suggest making reviews if you're writing a reply comment	Jan 23 2020, 1:12 PM
7fcb67118b74	0a275ced376f	418ab2ce2b25	Dan Leinir Turthra Jensen	Use NewCommentSheet to let users create comments on entries without	Jan 23 2020, 1:04 PM
418ab2ce2b25	745c371ebb3a	916eb7df321e	Dan Leinir Turthra Jensen	Pull out the new comments sheet into a component	Jan 23 2020, 1:04 PM
916eb7df321e	d1b4b4312721	b4df4696542b	Dan Leinir Turthra Jensen	Call in and request the credentials editor if none exist	Jan 23 2020, 11:00 AM
b4df4696542b	f5cf9cacc2f9	0ea518c864c2	Dan Leinir Turthra Jensen	Add an invokable to the KNSQuick Engine for editing credentials	Jan 23 2020, 10:59 AM
0ea518c864c2	e38f6852e585	51837efd6b2e	Dan Leinir Turthra Jensen	Add functionality to request a credentials editor from KNSCore::Engine	Jan 23 2020, 10:58 AM
51837efd6b2e	5ab6f3671683	e87b2c7e2392	Dan Leinir Turthra Jensen	Implement edit credentials in the Attica provider	Jan 23 2020, 10:58 AM
e87b2c7e2392	155ffb09ceeb	6210293c80c3	Dan Leinir Turthra Jensen	Add editCredentials to the knscore provider interface	Jan 23 2020, 10:57 AM
6210293c80c3	bf09a602d637	2ecce141310e	Dan Leinir Turthra Jensen	Hook up to the functions which do the actual vote/comment work	Jan 22 2020, 2:11 PM
2ecce141310e	d0e075f6654a	c4498e416d8a	Dan Leinir Turthra Jensen	Use the votable prop to add voting UI to entry details	Jan 22 2020, 2:06 PM
c4498e416d8a	bf86e443a401	b0eb569ab177	Dan Leinir Turthra Jensen	Add a voting method to the Ratings component (separate to editable)	Jan 22 2020, 2:06 PM
b0eb569ab177	c52acc68c3a7	6a9b82a33bce	Dan Leinir Turthra Jensen	Add reply request functionality to the comment delegate	Jan 22 2020, 1:29 PM
6a9b82a33bce	8ee27dbae6f6	b5eebae81345	Dan Leinir Turthra Jensen	Clean up the layouting of the comments sheet (thanks for the help, @mart!)	Jan 22 2020, 1:28 PM
b5eebae81345	d4f93d84d16c	97d1bb120b3a	Dan Leinir Turthra Jensen	Forward the userCanComment information from the items model	Jan 22 2020, 1:27 PM
97d1bb120b3a	d125e14bc059	a3e19528052b	Dan Leinir Turthra Jensen	Initial new-comment sheet (needs some layout work)	Jan 21 2020, 1:50 PM
a3e19528052b	30286ae3ed8d	a1aa7533de05	Dan Leinir Turthra Jensen	Allow clearing the Rating control when editable	Jan 21 2020, 1:50 PM
a1aa7533de05	bcfd7e546768	14957cc4f091	Dan Leinir Turthra Jensen	[WIP] Implement comment posting (and reenable voting) (Show More…)	Jan 20 2020, 2:26 PM
14957cc4f091	f0ddbdee1123	d57a6f97791f	Dan Leinir Turthra Jensen	Entry details checks for voting ability	Jan 20 2020, 2:26 PM
d57a6f97791f	0a882ca6b155	e4ec90f947f9	Dan Leinir Turthra Jensen	Add voting function to the quickitemsmodel (and userCanVote role)	Jan 20 2020, 2:25 PM
e4ec90f947f9	edee5f7e212c	02cff37a384e	Dan Leinir Turthra Jensen	Add invokable functions for creating comments (and reviews)	Jan 20 2020, 2:25 PM
02cff37a384e	0e61636f0e59	d4030add8116	Dan Leinir Turthra Jensen	Implement comment posting (and userCanVote check)	Jan 20 2020, 2:24 PM
d4030add8116	b6c69ec2e099	198e589d5df5	Dan Leinir Turthra Jensen	Add signals to fake a virtual function for posting a comment	Jan 20 2020, 2:23 PM

[WIP] Implement comment posting (and reenable voting)
Needs ReviewPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 74230

src/attica/atticaprovider.cpp

src/attica/atticaprovider_p.h

src/core/commentsmodel.h

src/core/commentsmodel.cpp

src/core/engine.h

src/core/engine.cpp

src/core/provider.h

src/qtquick/qml/EntryDetails.qml

src/qtquick/qml/private/EntryCommentDelegate.qml

src/qtquick/qml/private/EntryCommentsPage.qml

src/qtquick/qml/private/NewCommentSheet.qml

src/qtquick/qml/private/Rating.qml

src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml

src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

src/qtquick/quickengine.h

src/qtquick/quickengine.cpp

src/qtquick/quickitemsmodel.h

src/qtquick/quickitemsmodel.cpp

src/ui/entrydetailsdialog.cpp

src/ui/itemsviewdelegate.cpp

[WIP] Implement comment posting (and reenable voting)Needs ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 74230

src/attica/atticaprovider.cpp

src/attica/atticaprovider_p.h

src/core/commentsmodel.h

src/core/commentsmodel.cpp

src/core/engine.h

src/core/engine.cpp

src/core/provider.h

src/qtquick/qml/EntryDetails.qml

src/qtquick/qml/private/EntryCommentDelegate.qml

src/qtquick/qml/private/EntryCommentsPage.qml

src/qtquick/qml/private/NewCommentSheet.qml

src/qtquick/qml/private/Rating.qml

src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml

src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

src/qtquick/quickengine.h

src/qtquick/quickengine.cpp

src/qtquick/quickitemsmodel.h

src/qtquick/quickitemsmodel.cpp

src/ui/entrydetailsdialog.cpp

src/ui/itemsviewdelegate.cpp

[WIP] Implement comment posting (and reenable voting)
Needs ReviewPublic
Actions

Revision Contents
Changeset List