Differential D26792

do not show "copy in english" when using C as locale
ClosedPublic
Actions

Authored by sitter on Jan 20 2020, 12:53 PM.

Details

Reviewers
mart
ngraham
Commits
R102:87d793d15f60: do not show "copy in english" when using C as locale
Summary

qlocale differentiates LANG=C from LANG=en_US for us it is
though as the native untranslated strings are english, so when
kinfocenter is invoked with C it will effectively be == en_US.
with that in mind we don't need the copy in english button when
using C.

BUG: 403368
FIXED-IN: 5.18.0

Test Plan

LANG=C.UTF-8 no longer causes the button to be visible

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jan 20 2020, 12:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2020, 12:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jan 20 2020, 12:53 PM
mart accepted this revision.Jan 20 2020, 12:53 PM
This revision is now accepted and ready to land.Jan 20 2020, 12:53 PM
ngraham accepted this revision.Jan 20 2020, 2:49 PM
Closed by commit R102:87d793d15f60: do not show "copy in english" when using C as locale (authored by sitter). · Explain WhyJan 20 2020, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73969

View Options

Modules/about-distro/src/Module.cpp

Loading...