Fix test since Konsole added icons to its actions
AbandonedPublic
Actions

Authored by meven on Jan 20 2020, 8:48 AM.

Details

Reviewers

Group Reviewers

Summary

Test Plan

ctest

Repository

R309 KService

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21372
Build 21390: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Jan 20 2020, 8:48 AM

How about we ship a desktop file here to test instead of using the one in the system?

It doesn't make much sense that there's this weird dependency here.

Yep, this would break the test for users of an older konsole, let's ship our own. I'm working on it.

In D26781#597778, @dfaure wrote:

Yep, this would break the test for users of an older konsole, let's ship our own. I'm working on it.

All right

			Path	Packages
M			autotests/kservicetest.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
d4d0021f02e6	a0e2e2bd5a50	9849bf7802cc	Méven Car	Fix test since Konsole added icons to its actions (Show More…)	Jan 20 2020, 8:30 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73915	9849bf7		Jan 20 2020, 8:48 AM	★	★