Differential D26776

Initial test implementation
ClosedPublic
Actions

Authored by adrianchavesfernandez on Jan 19 2020, 10:46 PM.

Details

Reviewers

ltoscano

Summary

Allow running tests with tox

Have tests log coverage data

Add a basic test for Catalog load, amounting for 7% test coverage

Test Plan

tests pass

Diff Detail

Repository

R1046 Pology

Branch

coverage (branched from python3)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21366
Build 21384: arc lint + arc unit

adrianchavesfernandez requested review of this revision.Jan 19 2020, 10:46 PM

adrianchavesfernandez created this revision.

Harbormaster completed remote builds in B21366: Diff 73902.Jan 19 2020, 10:46 PM

Thanks! Do you think it would be possible to split the tox part (requirements, setup.py) from the partial porting (almost all changes under pology/) ?

In D26776#597800, @ltoscano wrote:

Thanks! Do you think it would be possible to split the tox part (requirements, setup.py) from the partial porting (almost all changes under pology/) ?

You mean in Phabricator, to make reviewing easier, or in the final code commits? In my local branch I have them split in 3 commits (test setup with a dummy test, coverage data support added, and then this first test and the code changes needed to have it pass).

In D26776#598632, @adrianchavesfernandez wrote:

In D26776#597800, @ltoscano wrote:

Thanks! Do you think it would be possible to split the tox part (requirements, setup.py) from the partial porting (almost all changes under pology/) ?

You mean in Phabricator, to make reviewing easier, or in the final code commits? In my local branch I have them split in 3 commits (test setup with a dummy test, coverage data support added, and then this first test and the code changes needed to have it pass).

Sorry again for the delay. Ok, then please feel free to commit. I guess we could switch to invent if we need to have more commits like this.

This revision is now accepted and ready to land.Feb 19 2020, 10:58 PM

+1000 to moving to Invent, I’m much more used to that workflow.

@adrianchavesfernandez can you please push the sequence of changes directly?

I’ve moved this to https://invent.kde.org/sdk/pology/-/merge_requests/1 , where you can see the separate commits. Feel free to merge that or give feedback if you wish something changed.

Shall we close this?

Merged in https://invent.kde.org/sdk/pology/-/merge_requests/2

Revision Contents
Changeset List

		Path
M		.gitignore (2 lines)
M		README (10 lines)
M		pology/__init__.py (32 lines)
M		pology/catalog.py (15 lines)
M		pology/colors.py (2 lines)
M		pology/message.py (22 lines)
A	M	setup.py (22 lines)
A	M	tests/files/template.pot (15 lines)
A	M	tests/requirements.txt (2 lines)
A	M	tests/test_catalog.py (24 lines)
A	M	tox.ini (8 lines)

Commit	Tree	Parents	Author	Summary	Date
3283a6c10fc7	b83eb91273dc	74a6523b7042	Adrián Chaves	Add a basic test for Catalog load	Jan 19 2020, 10:42 PM
74a6523b7042	796f109d2a50	5a571abf1fa2	Adrián Chaves	Have tests log coverage data	Jan 19 2020, 9:41 PM
5a571abf1fa2	b260d4fa24c7	0a506ed1c066	Adrián Chaves	Set up tests	Jan 19 2020, 9:36 PM