Add new signal for default action activation
ClosedPublic

Authored by nicolasfella on Jan 19 2020, 6:35 PM.

Details

Summary

activated is an overloaded signal. Add a new signal to replace the argument-less overload.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jan 19 2020, 6:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 19 2020, 6:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 19 2020, 6:35 PM
davidedmundson requested changes to this revision.Jan 19 2020, 6:38 PM
davidedmundson added a subscriber: davidedmundson.

Concept ++

I think you've missed some change in knotification.cpp to actually emit this.

This revision now requires changes to proceed.Jan 19 2020, 6:38 PM
  • Actually emit it
davidedmundson accepted this revision.Jan 19 2020, 7:05 PM
This revision is now accepted and ready to land.Jan 19 2020, 7:05 PM
This revision was automatically updated to reflect the committed changes.