Differential D26767

[KMessageWidget] Subtract the correct margin
ClosedPublic
Actions

Authored by davidre on Jan 19 2020, 2:44 PM.

Details

Reviewers
SGOrava
ngraham
Group Reviewers
Frameworks
Commits
R236:2e2f06acac60: [KMessageWidget] Subtract the correct margin
Summary

The comment describes a 1px border but the border actually has a size of 2px.

Test Plan

Before:


After:

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Jan 19 2020, 2:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 19 2020, 2:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Jan 19 2020, 2:44 PM
davidre edited the test plan for this revision. (Show Details)Jan 19 2020, 2:45 PM
davidre added reviewers: Frameworks, svuorela.
davidre edited reviewers, added: SGOrava; removed: svuorela.
davidre updated this revision to Diff 73881.Jan 19 2020, 2:47 PM

Update comment

ngraham accepted this revision.Jan 21 2020, 1:21 AM
ngraham added a subscriber: ngraham.

Ah yep, this was probably my oversight when I ported it to use the flatter Kirigami style.

This revision is now accepted and ready to land.Jan 21 2020, 1:21 AM
Closed by commit R236:2e2f06acac60: [KMessageWidget] Subtract the correct margin (authored by davidre). · Explain WhyJan 23 2020, 9:47 AM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Jan 23 2020, 9:53 AM
broulik added inline comments.
src/kmessagewidget.cpp
214

Maybe instead make the width an int variable and use it in both places to future-proof it?

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (4 lines)

Diff 74195

View Options

src/kmessagewidget.cpp

Loading...