We have the same problem on Linux (if the server doesn't support rich text) and probably Android too. In notifybypopup we do this with QXmlStreamReader + some API from KCodecs, but your solution is much simpler and nicer.

Ideally this should be done in KNotification instead of the backends. Therefore we'd need some API in KNotificationPlugin/KNotification to indicate whether rich text is supported. The KNotificationManager code is quite convoluted currently, but it should be doable.

This would help our quest of making KNotifications Tier 1 ;-)

Drop dependency to KF5Codecs by using the new stripRichText function

Harbormaster completed remote builds in B21348: Diff 73875.Jan 19 2020, 1:45 PM

And here in clean with proper commits https://github.com/TheOneRing/knotifications/tree/rhichtext

vonreth retitled this revision from Strip richtext on Windows, as Windows does not support it to Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup .Jan 19 2020, 1:52 PM

vonreth edited the summary of this revision. (Show Details)

you can push the two commits directly

src/knotificationplugin.h
104	remove one empty line
src/notifybysnore.cpp
62	unrelated

This revision is now accepted and ready to land.Jan 19 2020, 3:16 PM

Whitespace

Harbormaster completed remote builds in B21355: Diff 73884.Jan 19 2020, 3:52 PM

whitespace

Harbormaster completed remote builds in B21356: Diff 73885.Jan 19 2020, 3:53 PM

nicolasfella accepted this revision.Jan 19 2020, 3:56 PM

Closed by commit R289:4f2b04a171c3: Strip richtext on Windows (authored by vonreth). · Explain WhyJan 19 2020, 4:08 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/knotificationplugin.h (7 lines)
M			src/notifybysnore.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73849	41b270f		Jan 18 2020, 11:53 PM	★	★
Diff 2	73850	41b270f	Switch to QTextDocumentFragment	Jan 19 2020, 12:18 AM	★	★
Diff 3	73875	424fc98	- Drop dependency to KF5Codecs by using the new stripRichText function	Jan 19 2020, 1:45 PM	★	★
Diff 4	73884	424fc98	Whitespace	Jan 19 2020, 3:52 PM	★	★
Diff 5	73885	424fc98	whitespace	Jan 19 2020, 3:53 PM	★	★
Diff 6	73887	424fc98	R289:4f2b04a171c37e3f74e0a97dfd4a8b5efd76f04b	Jan 19 2020, 4:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8dc74a146f99	616ead68cc82	41d6aebaf999	Hannah von Reth	Drop dependency to KF5Codecs by using the new stripRichText function	Jan 19 2020, 1:42 PM
41d6aebaf999	eb564cac5494	424fc980d9e3	Hannah von Reth	Strip richtext on Windows, as Windows does not support it (Show More…)	Jan 19 2020, 11:17 AM

Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 73887

src/knotificationplugin.h

src/notifybysnore.cpp

Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopupClosedPublicActions