When a Krusader user launches Synchronizer, the Compare button is the default one, therefore the user only has to press Return to start the comparison.
However, if then the user selects a Synchronizer profile, the focus switches from the Compare button to the Close button, therefore pressing Return closes Synchronizer ("but I have selected a profile for something, haven't I?"). This proposal solves that.
Details
Details
- Reviewers
yurchor abika - Group Reviewers
Krusader - Commits
- R167:5c79a2790110: Synchronizer: Set the focus on the Compare button after selecting a profile
Open Synchronizer, create two profiles. Select one, press Return and see that the comparison starts. Do the same with the other profile.
Additionally, a useraction can also be made and executed, one like:
%_Sync("one_profile")% %_Sync("another_profile")%
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Thanks Toni. Works as expected.
But i still would recommend to either use btnCompareDirs->setFocus(); directly instead, or to add a short comment that syncList is focused to have the compare dirs button (which is set as default) being executed on pressing "Enter".
Otherwise it is a bit confusing why the empty tree widget is focused.
Comment Actions
Previously, syncList->setFocus(); was utilized as it was used in three other places in the same file, although with btnCompareDirs->setFocus(); the intentions becomes clearer. Thanks, Alex! (and Yuri :-)