The plan is to use a filter function in KApplicationTrader,
so the internal function behind the "subseq" operator needs to
be made public.
Details
Details
- Reviewers
michaeleden aacid davidedmundson
ctest
Diff Detail
Diff Detail
- Repository
- R309 KService
- Branch
- subseq
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21301 Build 21319: arc lint + arc unit
Comment Actions
Other than that, makes sense.
| src/services/kservice.h | ||
|---|---|---|
| 576 | Can we give it a better name? How about something like isContained? or at least isSubsequence. | |
Comment Actions
isContained() sounds like QString::contains().
I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying.
This means merging with D25698 then. What do you think?
Comment Actions
I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying.
This means merging with D25698 then. What do you think?
+1 makes sense to me