Launch plugin with argument, change signals

Authored by alex on Jan 17 2020, 8:54 PM.



The kcms/runners plugin is now able to launch a specific plugin using the --arg parameter of kcmshell5 and the deprecated signals have been changed.
And the QLatin1String has been replaced by the QStringLiteral Macro, because the open config method does not have an overload with the QLatin1String class.

Test Plan

You can just type "kcmshell5 plasmasearch --args Dictionary" and additionally to the KRunner configs it should open the plugin config

Diff Detail

R119 Plasma Desktop
No Linters Available
No Unit Test Coverage
Build Status
Buildable 21297
Build 21315: arc lint + arc unit
alex created this revision.Jan 17 2020, 8:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2020, 8:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Jan 17 2020, 8:54 PM
apol added a subscriber: apol.Jan 17 2020, 11:31 PM

Looks good to me overall. Can you commit the HACKING change separately? it's completely unrelated.

alex updated this revision to Diff 73814.Jan 18 2020, 6:47 AM

As requested the update of the HACKING file will be committed separately.

apol added a comment.Jan 19 2020, 11:19 PM

+1 to me, hopefully someone more familiar with this code can review, otherwise I'll approve it.

mart accepted this revision.Jan 22 2020, 10:05 AM
This revision is now accepted and ready to land.Jan 22 2020, 10:05 AM
alex edited the summary of this revision. (Show Details)Mar 18 2020, 12:33 PM
alex retitled this revision from Fix typo, launch plugin with argument, change signals to Launch plugin with argument, change signals.
This revision was automatically updated to reflect the committed changes.