[Breeze Cursors] Add some more cursor names
ClosedPublic

Authored by broulik on Jan 17 2020, 12:44 PM.

Details

Summary

They are "up for discussion" [1] but seem to be used by e.g. Chrome.

[1] https://www.freedesktop.org/wiki/Specifications/cursor-spec/

Test Plan

Juts a bunch of symlinks, so 5.18
Not sure where that cursorList file is being used (I also added some others that weren't added to this file in eb3498d9a797e3e21f0e722ecc0c9507c6f1b8ea

Now works

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 17 2020, 12:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2020, 12:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 17 2020, 12:44 PM
ngraham accepted this revision.Jan 17 2020, 1:14 PM
ngraham added a subscriber: ngraham.

I suppose it doesn't hurt anything to add these even though they're still "up for discussion."

This revision is now accepted and ready to land.Jan 17 2020, 1:14 PM

even though they're still "up for discussion."

Yeah, and then I looked at the date ;)

This revision was automatically updated to reflect the committed changes.

Hello,

I'm the person the reported this issue to the Chromium team. The fix they made will probably land only on Chromium 81 or later, but a lot of Electron apps will still rely on older versions of Chromium for a long time, where this missing cursors issue will still be present, unless they upgrade to Plasma 5.18.

Speaking of which, I just upgraded to Plasma 5.18 myself, and it looks incredible, by the way. And this fix of yours is already present there too, which is great. However, I believe you unintentionally missed two CSS cursors: grab, and grabbing, which should be linked to openhand and closedhand, respectively. The rest of cursors are fine and can be tested here:

http://elektronotdienst-nuernberg.de/bugs/cursor.html

So, it'd be great if you added those too.

Thanks!

Hello,

I'm the person the reported this issue to the Chromium team. The fix they made will probably land only on Chromium 81 or later, but a lot of Electron apps will still rely on older versions of Chromium for a long time, where this missing cursors issue will still be present, unless they upgrade to Plasma 5.18.

Speaking of which, I just upgraded to Plasma 5.18 myself, and it looks incredible, by the way. And this fix of yours is already present there too, which is great. However, I believe you unintentionally missed two CSS cursors: grab, and grabbing, which should be linked to openhand and closedhand, respectively. The rest of cursors are fine and can be tested here:

http://elektronotdienst-nuernberg.de/bugs/cursor.html

So, it'd be great if you added those too.

Thanks!

Great, I'm glad you're happy with it!

As you can see here, the change is pretty simple. Would you like to try your hand at submitting a patch to add the two missing cursors, modeled on this one?

Alright, I'll try :)

Thanks! Our documentation can be found at:

If you run into trouble, feel free to ask for help in the #kde-devel Matrix/Freenode IRC room, or send an email to kde-devel@kde.org.