[MPRIS Data Engine] Support player proxying for another one
ClosedPublic

Authored by broulik on Jan 16 2020, 8:58 AM.

Details

Summary

Plasma Browser Integration provides controls for Chrome, so when a player with kde:pid metadata is found, it is preferred over the actual pid it represents.

Test Plan

Still behaves as before:

  • It never switches away from a playing player when another starts playing
  • It switches to a playing player if there was none before
  • When current player gets paused, it switches to another playing one, if any, or a paused one, if any, or a stopped one, if any. When the current player gets paused and there is no playing one, it makes sure to prefer the paused proxy over another random paused player.
  • Closing a player, switches to another play one, if any, or a paused one, if any, or a stopped one, if any
  • Verified that it never used Chrome's broken mpris when p-b-i was running
  • When disabling p-b-i controls were transferred to Chrome's own mpris

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 16 2020, 8:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2020, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 16 2020, 8:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2020, 11:01 AM
This revision was automatically updated to reflect the committed changes.