Differential D26701

Add KFileCustomDialog constructor with a startDir parameter.
ClosedPublic
Actions

Authored by dfaure on Jan 15 2020, 10:51 PM.

Details

Reviewers
broulik
pino
mlaurent
Commits
R241:31ec03bf301c: Add KFileCustomDialog constructor with a startDir parameter.
Summary

This is needed because KFileWidget does special handling of the startDir
parameter (to detect if it's directory+filename), while setUrl() assumes
it's a directory.

Test Plan

tested with D26645 in kolourpaint

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21214
Build 21232: arc lint + arc unit
dfaure created this revision.Jan 15 2020, 10:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 15 2020, 10:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jan 15 2020, 10:51 PM
dfaure updated this revision to Diff 73668.Jan 15 2020, 10:51 PM

off-by-10

alexeymin added a subscriber: alexeymin.Jan 15 2020, 11:08 PM
alexeymin added inline comments.
src/filewidgets/kfilecustomdialog.h
40 ↗(On Diff #73668)

Constructs?

45 ↗(On Diff #73668)

Constructs?

dfaure updated this revision to Diff 73671.Jan 15 2020, 11:19 PM

Fix docu (oops, I'm tired)

mlaurent accepted this revision.Jan 22 2020, 1:00 PM

it's ok for me.

This revision is now accepted and ready to land.Jan 22 2020, 1:00 PM
dfaure closed this revision.Jan 22 2020, 1:02 PM

Revision Contents
Changeset List

Diff 73671

View Options

src/filewidgets/kfilecustomdialog.h

Loading...
View Options

src/filewidgets/kfilecustomdialog.cpp

Loading...