Differential D26698

[widgetexplorer] Fix animate in animation
ClosedPublic
Actions

Authored by davidedmundson on Jan 15 2020, 8:45 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:977665254990: [widgetexplorer] Fix animate in animation
Summary

The animation in comes in from offscreen on the left.

"to: 0" was correct when we had one column. With the 2 column view it
means we animate two items on top of each other and jump when the
animation completes. We want to animate to the final position the item
will end up in.

It bugs me more than it probably should.

Test Plan

Search for "asdfasdfsadfsadf"
Remove search
Animation now looks ok, instead of horrific

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 15 2020, 8:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 15 2020, 8:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 15 2020, 8:45 PM
ngraham added a subscriber: ngraham.Jan 15 2020, 8:58 PM

Hmm, I don't notice a difference before and after this patch. Maybe I'm not noticing the original problem

ngraham accepted this revision.Jan 15 2020, 9:04 PM

Oh never mind, I see it now. Quite subtle! Nice fix.

This revision is now accepted and ready to land.Jan 15 2020, 9:04 PM
Closed by commit R119:977665254990: [widgetexplorer] Fix animate in animation (authored by davidedmundson). · Explain WhyJan 17 2020, 2:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73769

View Options

desktoppackage/contents/explorer/WidgetExplorer.qml

Loading...