Differential D26696

DocumentPrivate::postMessage: avoid multiple hash lookups
ClosedPublic
Actions

Authored by kossebau on Jan 15 2020, 8:10 PM.

Details

Reviewers
dhaumann
cullmann
Commits
R39:da4c983d1f6b: DocumentPrivate::postMessage: avoid multiple hash lookups

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 15 2020, 8:10 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 15 2020, 8:10 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 15 2020, 8:10 PM
kossebau added a comment.Jan 15 2020, 8:12 PM

Seen while forking the Message classes for KDevelop for some shell-level message area :) https://invent.kde.org/kde/kdevelop/merge_requests/87
Was confused initially by the old code, and then found it also less µ-optimized ;)

kossebau updated this revision to Diff 74712.Jan 30 2020, 5:04 PM

rebase to latest master
ping? :)

cullmann accepted this revision.Jan 30 2020, 6:28 PM
cullmann added a subscriber: cullmann.

Upsa, missed that, looks OK IMHO ;=)

This revision is now accepted and ready to land.Jan 30 2020, 6:28 PM
Closed by commit R39:da4c983d1f6b: DocumentPrivate::postMessage: avoid multiple hash lookups (authored by kossebau). · Explain WhyJan 30 2020, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (12 lines)

Diff 74723

View Options

src/document/katedocument.cpp

Loading...