BUG: 377653
FIXED-IN: 5.18.5
Details
- Reviewers
- None
- Group Reviewers
Plasma - Commits
- R119:8e0f525a9633: [KCMs/Standard Actions] Give KCMShell window a sane default size
R119:3ce99d4ce476: Merge branch 'Plasma/5.18'
Before:
After:
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I don't know of any netbooks shorter with screens shorter than 600px, which is why I chose 600. Also, the window is resizable to be smaller.
Is there a better way?
Is there a better way?
Depends what the goal is. To set a minimum size or to change the default size.
Commit title says one thing, comment says another.
The goal is to have a sane default size.
This patch in its current state seems to do that, since setting a minimum width and height on m_editor doesn't actually prevent it from being resized to be smaller due to its sizePolicy.
Note that a window's minimum size does not include decorations or the panel. I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 screen the buttons are likely hidden behind the panel.
kcms/standard_actions/standard_actions_module.cpp | ||
---|---|---|
73 | setMinimumSize() |
700 -> 600 to accommodate people who still have netbooks or run Plasma in a VM with a
tiny window because guest tools aren't installed