[sddm-theme] Don't have a broken reveal password button
ClosedPublic

Authored by davidedmundson on Jan 14 2020, 10:14 PM.

Details

Summary

sddm-greeter will have a button for the reveal password button, but due
to sddm-greeter not loading a relevant QPT has no code to force it to
load the breeze icon set.

Without the breeze icon set, the clear button does not show.

There are ways to solve this, but none are trivial or reliable.

I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
but the bug has still not been fixed since.

BUG: 396039
CCBUG: 387418

Diff Detail

Repository
R120 Plasma Workspace
Branch
origin-master (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21156
Build 21174: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptJan 14 2020, 10:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 14 2020, 10:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2020, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Is there an SDDM issue to track this? Because I edited the file to make revealPasswordButtonShown true, and the button shows up just fine. Which makes me think this might've been fixed in SDDM.

Is there an SDDM issue to track this? Because I edited the file to make revealPasswordButtonShown true, and the button shows up just fine. Which makes me think this might've been fixed in SDDM.

I am not sure, but I think the issue is when the breeze icon theme isn't available, then the button would be shown without an icon, i.e. invisible, and we got bug reports of users hitting hit by mistake. Given the nature of the text box we're dealing with here, hitting that invisible button by mistake is problematic security-wise.

ahmadsamir added a comment.EditedOct 1 2021, 2:13 PM

One way to fix this is if sddm have copies of the needed password buttons, then it should work regardless of the installed icon themes.

I see. So the bug is seen only if Breeze icons aren't installed? Because I read that it happened only on some systems, but I didn't know which exactly.

Doesn't/shouldn't PC3 fall back to other icon themes if Breeze isn't installed?

we could install an icon into hicolor as fallback

we could install an icon into hicolor as fallback

Some time ago I tried finding which icon was being used, but I didn't get anywhere and moved on (I copied the theme folder, modified the file to show the password and used the custom theme ever since).