Differential D2663

Add view even if document is not proper UrlDocument
ClosedPublic
Actions

Authored by cordlandwehr on Sep 5 2016, 10:43 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R33:87a69ce3b5f3: Add view even if document is not proper UrlDocument
R32:87a69ce3b5f3: Add view even if document is not proper UrlDocument
Summary

This fixes the viewactivation unit test in Sublime.

Test Plan

run unit test

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr updated this revision to Diff 6440.Sep 5 2016, 10:43 AM
cordlandwehr retitled this revision from to Add view even if document is not proper UrlDocument.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added reviewers: KDevelop, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 5 2016, 10:43 AM
kfunk accepted this revision.Sep 5 2016, 11:43 AM
kfunk edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 5 2016, 11:43 AM
mwolff added a subscriber: mwolff.Sep 5 2016, 12:46 PM

how is this affecting stuff at runtime though? is maybe the unit test wrong? I mean having a tab with an empty title doesn't sound like a good diea...

Closed by commit R33:87a69ce3b5f3: Add view even if document is not proper UrlDocument (authored by cordlandwehr). · Explain WhySep 5 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msublime/container.cpp (11 lines)

Diff 6452

View Options

sublime/container.cpp

Loading...