Differential D26639

Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists
ClosedPublic
Actions

Authored by ndavis on Jan 13 2020, 7:51 PM.

Details

Reviewers
hpereiradacosta
ngraham
Group Reviewers
VDG
Breeze
Commits
R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window Background in windows and View…
Summary

If the widget has an item view parent, use the View Background color. Otherwise, use Window Background.

Test Plan

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jan 13 2020, 7:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 13 2020, 7:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jan 13 2020, 7:51 PM
ndavis edited the summary of this revision. (Show Details)Jan 13 2020, 7:53 PM
ndavis added reviewers: hpereiradacosta, ngraham.
In D26572#593511, @hpereiradacosta wrote:

Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.

This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).

This doesn't seem to have any visual regressions like that.

ndavis added a comment.Jan 13 2020, 8:00 PM

After this patch, should I remove isSelectedItem()? It's currently unused.

ndavis edited the test plan for this revision. (Show Details)Jan 13 2020, 8:03 PM
ngraham accepted this revision as: VDG.Jan 13 2020, 8:04 PM

Visually +1, fixes the minor background color bug that came from the last commit.

ndavis updated this revision to Diff 73458.Jan 13 2020, 8:05 PM

Fix formatting

hpereiradacosta accepted this revision.Jan 13 2020, 9:04 PM
In D26639#593537, @ndavis wrote:
In D26572#593511, @hpereiradacosta wrote:

Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.

This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).

This doesn't seem to have any visual regressions like that.

That works yes (since you test for parent item view).
Also yes, feel free to remove the now unused isItemSelected.
Thanks for the patch !

This revision is now accepted and ready to land.Jan 13 2020, 9:04 PM
Closed by commit R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window Background in windows and View… (authored by ndavis). · Explain WhyJan 13 2020, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/breezestyle.cpp (6 lines)

Diff 73460

View Options

kstyle/breezestyle.cpp

Loading...