Differential D26629

Fix crash when opening an attachment.
ClosedPublic
Actions

Authored by dfaure on Jan 13 2020, 3:25 PM.

Details

Reviewers
mlaurent
Commits
R865:c3308d753fa7: Fix crash when opening an attachment.
Summary

takeAt() invalidated the iterator...
and (*it) already changes the item in the container anyway, so none of
this is necessary.

Test Plan

No longer crashes

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21053
Build 21071: arc lint + arc unit
dfaure requested review of this revision.Jan 13 2020, 3:25 PM
dfaure created this revision.
dfaure updated this revision to Diff 73423.Jan 13 2020, 3:26 PM

stupid arc

dfaure retitled this revision from The revert from Volker that fixes an assert for me to Fix crash when opening an attachment..Jan 13 2020, 3:26 PM
dfaure edited the summary of this revision. (Show Details)
mlaurent accepted this revision.Jan 13 2020, 3:27 PM

Thanks :)

This revision is now accepted and ready to land.Jan 13 2020, 3:27 PM
dfaure updated this revision to Diff 73428.Jan 13 2020, 3:32 PM
dfaure edited the summary of this revision. (Show Details)

even simpler

mlaurent accepted this revision.Jan 13 2020, 3:33 PM
dfaure closed this revision.Jan 13 2020, 3:36 PM

Revision Contents
Changeset List

Diff 73421

View Options

src/apps/qml/ActiveChat.qml

Loading...
View Options

src/apps/qml/messages/MessageBase.qml

Loading...
View Options

src/apps/qml/messages/NewDateLabel.qml

Loading...
View Options

src/ruqolacore/model/messagemodel.cpp

Loading...