Fix crash when opening an attachment.
ClosedPublic

Authored by dfaure on Mon, Jan 13, 3:25 PM.

Details

Summary

takeAt() invalidated the iterator...
and (*it) already changes the item in the container anyway, so none of
this is necessary.

Test Plan

No longer crashes

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21058
Build 21076: arc lint + arc unit
dfaure requested review of this revision.Mon, Jan 13, 3:25 PM
dfaure created this revision.
dfaure updated this revision to Diff 73423.Mon, Jan 13, 3:26 PM

stupid arc

dfaure retitled this revision from The revert from Volker that fixes an assert for me to Fix crash when opening an attachment..Mon, Jan 13, 3:26 PM
dfaure edited the summary of this revision. (Show Details)
mlaurent accepted this revision.Mon, Jan 13, 3:27 PM

Thanks :)

This revision is now accepted and ready to land.Mon, Jan 13, 3:27 PM
dfaure updated this revision to Diff 73428.Mon, Jan 13, 3:32 PM
dfaure edited the summary of this revision. (Show Details)

even simpler

mlaurent accepted this revision.Mon, Jan 13, 3:33 PM
dfaure closed this revision.Mon, Jan 13, 3:36 PM