KEMailSettings: group names in kconfig files should not be localized
AcceptedPublic

Authored by meven on Jan 13 2020, 1:07 PM.

Details

Reviewers
ervin
dfaure
Group Reviewers
Frameworks
Summary

This breaks compatiblity with xdg-email for some locals (i.e french) since it is a sh with no utf-8/latin1 compatiblity.

Diff Detail

Repository
R237 KConfig
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21043
Build 21061: arc lint + arc unit
meven created this revision.Jan 13 2020, 1:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 13 2020, 1:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 13 2020, 1:07 PM
meven retitled this revision from KEMailSettings: key names in kconfig files do not need to be localized to KEMailSettings: group names in kconfig files should not be localized.Jan 13 2020, 1:08 PM
ervin added a comment.Jan 20 2020, 1:29 PM

That being said we did that change on purpose in 2002 (commit 38d35cec68bb718ebc97f965b66313082ab2c3b6 in kdelibs), granted xdg-email wasn't around at the time but I wonder if we thus want to move back from a translated "Default" name now?

Inviting @dfaure in here, he was around at the time, I wasn't I started only the summer after. ;-)

@mlaurent Does KMail show the profile name in the UI? I think this is why the profile name was translated, back then.

It's not used in kmail it seems.
we use this class in kmail-account-wizard only.

dfaure accepted this revision.Jan 23 2020, 9:46 PM

OK. I'm pretty sure this used to be shown "as is" in kmail, VERY LONG ago.

This revision is now accepted and ready to land.Jan 23 2020, 9:46 PM