RFC: [Notifications] Raise application window if no default action is provided
ClosedPublic
Actions

Authored by broulik on Jan 13 2020, 1:02 PM.

Details

Reviewers

hein
mart

Group Reviewers

Plasma
VDG

Commits

Summary

BUG: 416107

Test Plan

Clicked Thunderbird notification, got Thunderbird window raised
Opened new composer window, brought Thunderbird into the front, activated another window, Thunderbird window got raised and not the composer matching the stacking order

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jan 13 2020, 1:02 PM

This revision is now accepted and ready to land.Jan 13 2020, 1:25 PM

+1 conceptually. I think this is a nice default behavior for the apps that haven't implemented nicer behaviors themselves, or refuse to.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/notifications/package/contents/ui/NotificationPopup.qml (1 line)
M			applets/notifications/package/contents/ui/global/Globals.qml (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73403			Jan 13 2020, 1:01 PM	★	★
Diff 2	73497	1d6b537	R120:48d3613aa843ba5b27c11cadd4ac85a98fdf280c	Jan 14 2020, 9:59 AM	★	★