Remove widget arg from KNotification ctor
ClosedPublic

Authored by nicolasfella on Mon, Jan 13, 12:55 AM.

Details

Summary

passing a widget will be removed in KF6 and doesn't really do anything here.

Test Plan

Builds

Diff Detail

Repository
R154 KDE Telepathy Text User Interface
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Mon, Jan 13, 12:55 AM
nicolasfella created this revision.
akulichalexandr accepted this revision.Mon, Jan 13, 1:22 AM
This revision is now accepted and ready to land.Mon, Jan 13, 1:22 AM

Doesn't this raise the window or something by default?

Doesn't this raise the window or something by default?

True. I have an idea on how to do this in the future, but for now I'll not change that one

So, does this patch break this feature or is it broken already?

  • Partially revert

RaiseWidgetOnActivation never worked, but CloseWhenWidgetActivated does work

This revision was automatically updated to reflect the committed changes.