Differential D26609

[kstyle] Port to KWindowSystem shadows API
ClosedPublic
Actions

Authored by zzag on Jan 12 2020, 6:55 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Maniphest Tasks
T12496: Shadows API in KWindowSystem
Commits
R113:164dbdb334b8: [kstyle] Port to KWindowSystem shadows API

Diff Detail

Repository
R113 Oxygen Theme
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21198
Build 21216: arc lint + arc unit
zzag created this revision.Jan 12 2020, 6:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2020, 6:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jan 12 2020, 6:55 PM
davidedmundson added a subscriber: davidedmundson.Jan 15 2020, 4:42 PM
davidedmundson added inline comments.
kstyle/oxygenshadowhelper.cpp
291–292

I don't understand what this line is trying to do

zzag updated this revision to Diff 73644.Jan 15 2020, 6:38 PM
  • Drop sub-surface check
  • Don't use obsolete QWidget::isTopLevel()
zzag marked an inline comment as done.Jan 15 2020, 6:40 PM
zzag added inline comments.
kstyle/oxygenshadowhelper.cpp
291–292

I presume that it acted as a sub-surface test, in either case we don't need it.

davidedmundson accepted this revision.Jan 21 2020, 11:17 PM
This revision is now accepted and ready to land.Jan 21 2020, 11:17 PM
Closed by commit R113:164dbdb334b8: [kstyle] Port to KWindowSystem shadows API (authored by zzag). · Explain WhyJan 22 2020, 12:27 AM
This revision was automatically updated to reflect the committed changes.
zzag marked an inline comment as done.

Revision Contents
Changeset List

Diff 73644

View Options

kstyle/oxygenshadowhelper.h

Loading...
View Options

kstyle/oxygenshadowhelper.cpp

Loading...