Differential D26587

[GTK3] Improve Electron menubar legibility
ClosedPublic
Actions

Authored by cblack on Jan 11 2020, 5:32 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Breeze
Commits
R98:c9ac507ff3c2: [GTK3] Improve Electron menubar legibility
Summary

Electron apps using a menubar are now more legible. This has the side effect of
forcing background tabs in Chrome/ium to not have an inactive appearance, as window > menubar
provides the styling for both Electron's menubar and Chrome/ium's tabs.

BUG: 413915
FIXED-IN: 5.18

Test Plan

Before:

After:

Diff Detail

Repository
R98 Breeze for Gtk
Branch
electron-menubar-fix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20967
Build 20985: arc lint + arc unit
cblack created this revision.Jan 11 2020, 5:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2020, 5:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Jan 11 2020, 5:32 PM
cblack edited the test plan for this revision. (Show Details)Jan 11 2020, 5:33 PM
cblack added reviewers: VDG, Breeze.
ndavis accepted this revision.Jan 11 2020, 5:37 PM
ndavis added a subscriber: ndavis.

I think this is fine.

This revision is now accepted and ready to land.Jan 11 2020, 5:37 PM
ndavis added inline comments.Jan 11 2020, 5:40 PM
src/gtk3/applications/_chromium.scss
6

Unless you think we need this in here, this line should be removed.

cblack updated this revision to Diff 73287.Jan 11 2020, 5:43 PM

Remove commented line

cblack edited the summary of this revision. (Show Details)Jan 11 2020, 5:45 PM
Closed by commit R98:c9ac507ff3c2: [GTK3] Improve Electron menubar legibility (authored by cblack). · Explain WhyJan 11 2020, 5:46 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Jan 11 2020, 6:04 PM

Hmm this makes inactive tabs even harder to spot than already :/

ndavis added a comment.Jan 11 2020, 6:16 PM
In D26587#592088, @broulik wrote:

Hmm this makes inactive tabs even harder to spot than already :/

There's really not much we can do about Chromium when every Electron app uses the custom CSS we have for Chromium. We've at least got different colors for inactive tab and active tab backgrounds. I guess one could say they should have done something like what Firefox did with their tabs, but that's probably a moot point.

Revision Contents
Changeset List

Diff 73287

View Options

src/gtk3/applications/_chromium.scss

Loading...