[GTK3] Improve Electron menubar legibility
ClosedPublic

Authored by cblack on Sat, Jan 11, 5:32 PM.

Details

Summary

Electron apps using a menubar are now more legible. This has the side effect of
forcing background tabs in Chrome/ium to not have an inactive appearance, as window > menubar
provides the styling for both Electron's menubar and Chrome/ium's tabs.

BUG: 413915
FIXED-IN: 5.18

Test Plan

Before:

After:

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sat, Jan 11, 5:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Jan 11, 5:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sat, Jan 11, 5:32 PM
cblack edited the test plan for this revision. (Show Details)Sat, Jan 11, 5:33 PM
cblack added reviewers: VDG, Breeze.
ndavis accepted this revision.Sat, Jan 11, 5:37 PM
ndavis added a subscriber: ndavis.

I think this is fine.

This revision is now accepted and ready to land.Sat, Jan 11, 5:37 PM
ndavis added inline comments.Sat, Jan 11, 5:40 PM
src/gtk3/applications/_chromium.scss
6

Unless you think we need this in here, this line should be removed.

cblack updated this revision to Diff 73287.Sat, Jan 11, 5:43 PM

Remove commented line

cblack edited the summary of this revision. (Show Details)Sat, Jan 11, 5:45 PM
This revision was automatically updated to reflect the committed changes.

Hmm this makes inactive tabs even harder to spot than already :/

Hmm this makes inactive tabs even harder to spot than already :/

There's really not much we can do about Chromium when every Electron app uses the custom CSS we have for Chromium. We've at least got different colors for inactive tab and active tab backgrounds. I guess one could say they should have done something like what Firefox did with their tabs, but that's probably a moot point.