Load localization catalog for slideshow config window
ClosedPublic

Authored by yurchor on Sat, Jan 11, 3:50 PM.

Details

Summary

It was reported by Victor Ryzhykh that this patch fixes localization of the wallpaper slideshow config window.

Test Plan
  1. Open the config window in some ~100%-translated locale (ca, pt, sv, uk).
  2. All messages should be translated.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Sat, Jan 11, 3:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Jan 11, 3:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.Sat, Jan 11, 3:50 PM
ngraham accepted this revision.Sat, Jan 11, 4:16 PM
ngraham added a subscriber: ngraham.

Oops, forgot the translation domain, sorry! Thanks for the fix, folks.

I'm still not totally clear on why some things require a domain to be added for translations, and other things don't.

This revision is now accepted and ready to land.Sat, Jan 11, 4:16 PM
This revision was automatically updated to reflect the committed changes.

I'm still not totally clear on why some things require a domain to be added for translations, and other things don't.

Everything requires a domain set in some way.

For apps/C++ this is done effectively magically at compile time.

For QML we have to have some code somewhere that says "this QML context should use this i18n domain", which is all in kdeclarative. This is already quite messy, but the real complication is when one context loads a plugin from something else - we haven't solved that, so we specify a domain explicitly.