It was reported by Victor Ryzhykh that this patch fixes localization of the wallpaper slideshow config window.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma Localization - Commits
- R120:025387c931b3: Load localization catalog for slideshow config window
- Open the config window in some ~100%-translated locale (ca, pt, sv, uk).
- All messages should be translated.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Oops, forgot the translation domain, sorry! Thanks for the fix, folks.
I'm still not totally clear on why some things require a domain to be added for translations, and other things don't.
Comment Actions
I'm still not totally clear on why some things require a domain to be added for translations, and other things don't.
Everything requires a domain set in some way.
For apps/C++ this is done effectively magically at compile time.
For QML we have to have some code somewhere that says "this QML context should use this i18n domain", which is all in kdeclarative. This is already quite messy, but the real complication is when one context loads a plugin from something else - we haven't solved that, so we specify a domain explicitly.