Differential D26573

Add missing Import Env Variable
ClosedPublic
Actions

Authored by tcanabrava on Jan 10 2020, 9:35 PM.

Details

Reviewers
mart
Commits
R240:ee0531749057: Add missing Import Env Variable
Summary

Without this, in Qt 5.14 I get an android-like QQC2 theme
This used to work on Qt 5.13 so I assume that it's a regression

Diff Detail

Repository
R240 Extra CMake Modules
Branch
add_missing_env_var
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20927
Build 20945: arc lint + arc unit
tcanabrava created this revision.Jan 10 2020, 9:35 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 10 2020, 9:35 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jan 10 2020, 9:35 PM
mart accepted this revision.Jan 20 2020, 3:57 PM
This revision is now accepted and ready to land.Jan 20 2020, 3:57 PM
davidedmundson added a subscriber: davidedmundson.Jan 28 2020, 3:20 PM

I'm now affected by this :(

I think this shouldn't be needed, but I have no objections to merging this either.

https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/288238

apol added a subscriber: apol.Jan 28 2020, 3:28 PM

I don't really understand why this is needed, I've never needed that at least.

Having @davidedmundson's patch would be interesting too, although we might want to support earlier versions that won't get the patch.

tcanabrava updated this revision to Diff 74512.Jan 28 2020, 4:26 PM
  • Fix Variable
Closed by commit R240:ee0531749057: Add missing Import Env Variable (authored by tcanabrava). · Explain WhyJan 28 2020, 4:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkde-modules/prefix.sh.cmake (2 lines)

Diff 73237

View Options

kde-modules/prefix.sh.cmake

Loading...