Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:35dcbd3dd89c: Improve Plasma user feedback introspection
Manual testing
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21195 Build 21213: arc lint + arc unit
Comment Actions
Quite a clever solution. I like the general idea.
One major comment at the bottom, rest aren't important.
| kcms/feedback/feedback.cpp | ||
|---|---|---|
| 41 ↗ | (On Diff #73315) | where do you use this? |
| 109 ↗ | (On Diff #73315) | This doesn't look right. With 2 async processes, the second one to come in will replace the first? |
| kcms/feedback/package/contents/ui/main.qml | ||
| 90 ↗ | (On Diff #73315) | unrelated to this patch. |
| 144 ↗ | (On Diff #73315) | AFAIK we're deprecating this. Use of Kirigami.Icon would be preferred |
Comment Actions
Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching KUSerFeedback again?