Differential D26568

Port KRecursiveFilterProxyModel to QSortFilterProxyModel
ClosedPublic
Actions

Authored by ahmadsamir on Jan 10 2020, 6:35 PM.

Details

Reviewers
mwolff
Maniphest Tasks
T12269: Remove KRecursiveFilterProxyModel
Commits
R45:1691cdd142d3: Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Summary

Use QSortFilterProxyModel::filterAcceptsRow() instead of
KRecursiveFilterProxyModel::acceptRow().

Set setRecursiveFilteringEnabled(true) by default.

Test Plan

make && ctest.

Diff Detail

Repository
R45 Heaptrack
Branch
l-krecursive (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20941
Build 20959: arc lint + arc unit
ahmadsamir requested review of this revision.Jan 10 2020, 6:35 PM
ahmadsamir created this revision.
ahmadsamir added a comment.Jan 10 2020, 6:43 PM

QSortFilterProxyModel gained recursive filtering with Qt 5.10, should I set the min. required Qt version in CMakeLists.txt?

mwolff added a comment.Jan 22 2020, 8:27 AM

Hey, sorry for the long delay. I'm fine with this change in principle, but please then also increase the minimum Qt version required in CMake. It's currently set to 5.2 which is far too old. Please bump it to 5.10 to support this patch.

ahmadsamir updated this revision to Diff 74089.Jan 22 2020, 9:48 AM

Set requiered Qt version to 5.10

mwolff accepted this revision.Jan 22 2020, 11:39 AM

thanks, lgtm - do you have commit rights? if so, please push to master

This revision is now accepted and ready to land.Jan 22 2020, 11:39 AM
ahmadsamir added a comment.Jan 22 2020, 11:53 AM
In D26568#598729, @mwolff wrote:

thanks, lgtm - do you have commit rights? if so, please push to master

Done. :)

Closed by commit R45:1691cdd142d3: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir). · Explain WhyJan 22 2020, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73256

View Options

src/analyze/gui/mainwindow.cpp

Loading...
View Options

src/analyze/gui/treeproxy.h

Loading...
View Options

src/analyze/gui/treeproxy.cpp

Loading...