Differential D26566

Fix layout for the reviews sheet
ClosedPublic
Actions

Authored by mart on Jan 10 2020, 5:05 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R134:98898d6ac407: Fix layout for the reviews sheet
Summary
  • the main contentitem of a sheet should have *always* an explicit implicitWidth
  • never use anchors for delegates
Test Plan

ireviews sheet works ok now both in desktop and mobile modes
before:


after:

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20904
Build 20922: arc lint + arc unit
mart created this revision.Jan 10 2020, 5:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2020, 5:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Jan 10 2020, 5:05 PM
mart edited the test plan for this revision. (Show Details)Jan 10 2020, 5:06 PM
ngraham accepted this revision.Jan 10 2020, 5:45 PM
ngraham added a subscriber: ngraham.

Nice, thanks!

This revision is now accepted and ready to land.Jan 10 2020, 5:45 PM
Closed by commit R134:98898d6ac407: Fix layout for the reviews sheet (authored by mart). · Explain WhyJan 13 2020, 9:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73213

View Options

discover/qml/ReviewDelegate.qml

Loading...
View Options

discover/qml/ReviewsPage.qml

Loading...