Differential D26563

Proceed with deletion operations even if parts of it fail, or weren't done
ClosedPublic
Actions

Authored by vkrause on Jan 10 2020, 4:36 PM.

Details

Reviewers
apol
Commits
R849:77f99f54bc3d: Proceed with deletion operations even if parts of it fail, or weren't done
Summary

This allows us to recover from inconsistent states between what we expect
to be the schema, and what actually is in the database.

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause requested review of this revision.Jan 10 2020, 4:36 PM
vkrause created this revision.
apol added a comment.Jan 11 2020, 2:13 AM

+1
This makes sense, it's possibly what happened. I'm not sure how I made it happen though.

So it failed this bad because I added a wrong column?

vkrause added a comment.Jan 11 2020, 11:23 AM
In D26563#591734, @apol wrote:

+1
This makes sense, it's possibly what happened. I'm not sure how I made it happen though.

So it failed this bad because I added a wrong column?

This doesn't address how we got into that situation (nor do I know how that happened). I just manually recreated that state from SQL table dumps I got from, and tried to make the schema editor deal with it.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 7:23 PM
Closed by commit R849:77f99f54bc3d: Proceed with deletion operations even if parts of it fail, or weren't done (authored by vkrause). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73562

View Options

src/server/shared/datastore.php

Loading...
View Options

src/server/shared/product.php

Loading...
View Options

src/server/shared/schemaentryelement.php

Loading...