Differential D26562

Port KRecursiveFilterProxyModel to QSortFilterProxyModel
ClosedPublic
Actions

Authored by ahmadsamir on Jan 10 2020, 3:48 PM.

Details

Reviewers
ervin
Maniphest Tasks
T12269: Remove KRecursiveFilterProxyModel
Commits
R4:cb1e5e369fcf: Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Summary

Set setRecursiveFilteringEnabled(true) by default. Set required Qt
version to 5.10.0, that's where QSortFilterProxyModel gained recursive
filtering capability.

Test Plan

make && ctest. All unit tests pass except for a couple of them, but
these same ones fail on master too.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Jan 10 2020, 3:48 PM
ahmadsamir created this revision.
ahmadsamir updated this revision to Diff 73223.Jan 10 2020, 6:46 PM
ahmadsamir edited the summary of this revision. (Show Details)

Fix commit message

ervin accepted this revision.Jan 20 2020, 12:52 PM
This revision is now accepted and ready to land.Jan 20 2020, 12:52 PM
Closed by commit R4:cb1e5e369fcf: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir). · Explain WhyJan 20 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73940

View Options

CMakeLists.txt

Loading...
View Options

src/widgets/quickselectdialog.h

Loading...
View Options

src/widgets/quickselectdialog.cpp

Loading...